Toc updates for accessibility, part 1 #12244
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillWagner
force-pushed
the
remove-link-farms
branch
from
6a18457 to
4f36614
Compare
BillWagner
changed the title
|
This ended up bigger than I thought it would be. (The LINQ section had a lot more updates than I expected). Here's a summary of the kinds of changes made:
To clean links, when a child node had a single "see also" link to the parent, that link was removed. |
BillWagner
force-pushed
the
remove-link-farms
branch
3 times, most recently
from
bc9eda1 to
b122555
Compare
BillWagner
force-pushed
the
remove-link-farms
branch
from
b122555 to
5563db9
Compare
mairaw
reviewed
May 21, 2019
There was a problem hiding this comment.
I've reviewed up to advanced-linq-to-xml-programming.md. Looking good so far @BillWagner. Submitting my comments so far while I grab something to eat and then I'll go back to this.
docs/csharp/programming-guide/concepts/covariance-contravariance/toc.yml
Outdated
Show resolved
Hide resolved
BillWagner
force-pushed
the
remove-link-farms
branch
from
eb8455e to
a89f965
Compare
Where the index.md file in a folder was an overview, or similar, updates the TOC to provide a child node.
The keywords section of the language reference had several pages that were links, but no real content. Re-route those.
This one one got away from me a bit.
These updates respond to the first set of reviews.
Co-Authored-By: Maira Wenzel <[email protected]>
BillWagner
force-pushed
the
remove-link-farms
branch
from
a89f965 to
9863342
Compare
BillWagner
added a commit
to BillWagner/docs
that referenced
this pull request
May 28, 2019
Split from dotnet#12244 This covers the area under csharp/language-reference
BillWagner
added a commit
to BillWagner/docs
that referenced
this pull request
May 28, 2019
Split from dotnet#12244 This covers the area under csharp/language-reference
BillWagner
added a commit
to BillWagner/docs
that referenced
this pull request
May 29, 2019
Extracted from dotnet#12244 Remove a few areas in the TOC that are already redirectied.
BillWagner
added a commit
to BillWagner/docs
that referenced
this pull request
May 29, 2019
Extracted from dotnet#12244 This PR has the changes from the language-reference/keywords folder.
This was referenced May 29, 2019
BillWagner
added a commit
that referenced
this pull request
May 31, 2019
* Remove portal pages from keywords section Extracted from #12244 This PR has the changes from the language-reference/keywords folder. * remove portal files. * fix links to removed files. * respond to feedback.
This was referenced May 31, 2019
|
This was broken into several PRs, and each of those has been merged. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update a variety of TOC nodes to remove parent nodes with both content and children.
This is trying an experiment in the framework to see if it provides a better navigation experience.